Remove calls to resolve_tools - #2406
Draft
iteratee wants to merge 1 commit into
Draft
Conversation
iteratee
marked this pull request as draft
April 3, 2026 20:33
iteratee
force-pushed
the
kb/bazel86
branch
7 times, most recently
from
April 4, 2026 07:13
a9ff57d to
d63c0fe
Compare
iteratee
force-pushed
the
kb/bazel86
branch
4 times, most recently
from
August 25, 2026 05:45
3c1fa4d to
cca76fa
Compare
Replace them mostly with `FilesToRunProvider`s. For cc_wrapper, where repl's also need the runfiles, use a struct that has the executable, the `FilesToRunProvider` and the runfiles. The executable could be retrieved from the `FilesToRunProvider`, but it is more convenient to just have it in the struct. FilesToRunProvider also makes sure that when passed as a tool, all the necessary runfiles are available for that tool. Use this for protoc and cc_wrapper. cc_wrapper cannot rely on the RUNFILES_* environment variables. Pass cc_wrapper either its path or the path to its manifest directly. Make sure that we correctly pass around env variables at various points so that tools we depend are in the `PATH` and have the environment they expect. Remove outdated comment about re-enabling resolve_tools for bazel 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace them mostly with
FilesToRunProviders. For cc_wrapper, whererepl's also need the runfiles, use a struct that has the executable, the
FilesToRunProviderand the runfiles. The executable could be retrievedfrom the
FilesToRunProvider, but it is more convenient to just have itin the struct.
FilesToRunProvider also makes sure that when passed as a tool, all the
necessary runfiles are available for that tool. Use this for protoc and
cc_wrapper.
cc_wrapper cannot rely on the RUNFILES_* environment variables. Pass
cc_wrapper either its path or the path to its manifest directly.
Make sure that we correctly pass around env variables at various points
so that tools we depend are in the
PATHand have the environment theyexpect.
Remove outdated comment about re-enabling resolve_tools for bazel 8