Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule to factor out remote Nixpkgs repository common to all packages. #1

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

mboes
Copy link
Member

@mboes mboes commented Dec 10, 2017

If each nixpkgs_package rule specifies its own repository, then the
repository is fetched and extracted once per package. When we really
want to be doing that only once per repository. So we introduce a new
rule to define Nixpkgs repositories. nixpkgs_package rules can then
refer to these repositories by label.

@mboes mboes force-pushed the nixpkgs-git-rule branch 2 times, most recently from be12229 to f6eb360 Compare December 10, 2017 23:01
@mboes mboes requested a review from Fuuzetsu December 10, 2017 23:04
If each `nixpkgs_package` rule specifies its own repository, then the
repository is fetched and extracted once per package. When we really
want to be doing that only once per repository. So we introduce a new
rule to define Nixpkgs repositories. `nixpkgs_package` rules can then
refer to these repositories by label.
@mboes mboes merged commit 6a06c3e into master Dec 11, 2017
@mboes mboes deleted the nixpkgs-git-rule branch December 11, 2017 17:49
wolfd pushed a commit to wolfd/rules_nixpkgs that referenced this pull request Sep 15, 2021
Experimentation with adding more outputs from nix into bazel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants