Allow repository rule to check for sha #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leostera
force-pushed
the
add-sha-to-repo-rule
branch
from
74f4683 to
8bd1c48
Compare
|
Awesome! Any chance you could make the hash optional, just like it is for other repository rules? |
leostera
force-pushed
the
add-sha-to-repo-rule
branch
from
8bd1c48 to
0ae1177
Compare
|
@mboes done! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! And thanks a lot for putting these together :)
It felt a bit unidiomatic bazel usage to see that suggested sha every time I did a build because the rule didn't pass a sha along to
download_and_extract, so I figured I would contribute the fix.Easy peasy, now the contents of the repo are verified too! 🎉