Deprecate path #33
Merged
Deprecate path #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using explicit targets is better in all cases, plus the codepath of `path` has been broken for some time. We provide migration instructions on how to use the `repositories` attribute instead.
Make sure the migration instructions given for `path` actually work in practice.
Profpatsch
force-pushed
the
deprecate-path
branch
from
e0180b6 to
0338c74
Compare
mboes
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #32, this removes the
pathattribute fromrules_nixpkgs.Instead of deprecating it, I suggest the direct removal, since there is a pretty simple universal migration strategy, which is described in an addendum to the readme.