Remove dirname hack from nix_path concatenation
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we applied `dirname` to each path, which meant we could only use nix files named `default.nix` (because of nix’s defaulting to that file). Now we can name files directly (see the `WORKSPACE` file for an example that calls `nixpksgs-pin.nix`).
thufschmitt
approved these changes
Oct 23, 2018
mboes
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we applied
dirnameto each path, which meant we couldonly use nix files named
default.nix(because of nix’s defaulting tothat file). Now we can name files directly (see the
WORKSPACEfilefor an example that calls
nixpksgs-pin.nix).