Allow arbitrary expressions in attribute_path. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboes
reviewed
Dec 15, 2017
nixpkgs/nixpkgs.bzl
Outdated
| # example of this is haskellPackages.ghcWithPackages which is | ||
| # unusable with -A. | ||
| res = ctx.execute(["nix-build", path, "-E", | ||
| "(import <nixpkgs> {{}}).{0}".format(attr_path), |
There was a problem hiding this comment.
Also, if an attribute path is now really an expression, then the name should be changed and it should be documented.
??? |
Fuuzetsu
force-pushed
the
allow-expressions
branch
from
9763046 to
e908785
Compare
|
I changed the implementation a bit to allow arbitrary expressions and added a couple of tests. I hope they pass now. |
|
Hm, I think nix 1.12 is needed for |
The oracle here is CircleCI. Green on master but red on this branch. Can't merge until this one goes green. |
Fuuzetsu
force-pushed
the
allow-expressions
branch
from
e908785 to
ff76eb1
Compare
|
Turned out to be dumb mistake, should be green, PATAL. |
mboes
requested changes
Dec 25, 2017
nixpkgs/nixpkgs.bzl
Outdated
| """Generate a nix expression that picks a package from nixpkgs. | ||
| """ | ||
| if ctx.attr.attribute and ctx.attr.expression: | ||
| fail("'attribute' and 'expression' are mutually exclusive.") |
There was a problem hiding this comment.
I don't think the two should be mutually exclusive. -A and -E are not mutually exclusive flags to nix-build. When used together, -E e -A some.path means e.some.path. We should reproduce the same semantics here.
This allows us to be much more flexible when we want to be while maintaining convenience for simple attribute cases.
Fuuzetsu
force-pushed
the
allow-expressions
branch
from
ff76eb1 to
25f8361
Compare
|
Addressed. Didn't realise you could combine -E and -A. |
We really are passing an attribute *path*, not a Nix attribute. The Nix documentation defines an attribute path as a dot separated sequence of attributes.
mboes
approved these changes
Dec 26, 2017
|
Note: for now we're documenting attributes in README, not using inline docstrings. |
wolfd
pushed a commit
to wolfd/rules_nixpkgs
that referenced
this pull request
Sep 15, 2021
Move custom code out of nixpkgs subfolder. Wrap nix_cc with macro to use supports_nix constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more advanced attributes to be used. Motivating use-case
is ghcWithPackages.