Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9458: Add padding-right to IconCheck in MenuItemSelectAvatar #9467

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dev-kraken
Copy link
Contributor

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added padding-right to IconCheck component in MenuItemSelectAvatar to improve visual spacing in menu items with avatars.

  • Created new StyledIconCheck styled component in /packages/twenty-ui/src/navigation/menu-item/components/MenuItemSelectAvatar.tsx with padding-right property
  • Modified IconCheck implementation to use the new styled component for consistent spacing

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dev-kraken, I don't understand why so many changes have been made. could you elaborate on your changes?

@dev-kraken
Copy link
Contributor Author

Hi @dev-kraken, I don't understand why so many changes have been made. could you elaborate on your changes?

The only changes are made in the file src/navigation/menu-item/internals/components/StyledMenuItemBase.tsx are:

import { IconCheck } from '@ui/display';

and new component

export const StyledIconCheck = styled(IconCheck)`
    padding-right: ${({ theme }) => theme.spacing(2)};
`;

@charlesBochet
Copy link
Member

Here is what I see:
image

@dev-kraken
Copy link
Contributor Author

Here is what I see: image

Oh, I see the issue now. Prettier added an extra space, which has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants