Feat/2fa #9634
Draft
Feat/2fa #9634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasrouanne
commented
Jan 15, 2025
packages/twenty-server/src/engine/core-modules/auth/auth.resolver.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/auth.resolver.ts
Outdated
Show resolved
Hide resolved
nicolasrouanne
force-pushed
the
feat/2fa
branch
from
b24e435 to
e876cc3
Compare
nicolasrouanne
commented
Jan 16, 2025
Comment on lines
68
to
72
| @Field(() => [TwoFactorMethod], { nullable: true }) | ||
| @OneToMany( | ||
| () => TwoFactorMethod, | ||
| (twoFactorMethod) => twoFactorMethod.userWorkspace, | ||
| ) | ||
| twoFactorMethods: Relation<TwoFactorMethod[]>; |
There was a problem hiding this comment.
I added the twoFactorMethods relation in UserWorkspace, but for some reason, typeorm can't seem to find the association
/Users/nicolasrouanne/dev/twenty/src/metadata-builder/EntityMetadataBuilder.ts:1111
entityMetadata.relations.forEach((relation) => {
^
TypeORMError: Entity metadata for UserWorkspace#twoFactorMethods was not found. Check if you specified a correct entity object and if it's connected in the connection options.
at /Users/nicolasrouanne/dev/twenty/src/metadata-builder/EntityMetadataBuilder.ts:1121:23- also add a `is2FAEnabled` column to `userWorkspace` entity
nicolasrouanne
force-pushed
the
feat/2fa
branch
from
e876cc3 to
a4a360c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #7003
Implements 2FA with TOTP.
Warning
This is a draft PR, with only partial changes, made as a mean of discussion about #7003 (it's easier to reason about real code)
Behaviour
totpSecretis stored for each userotplibto create a QR code and to validate anotpagainst antotpSecret(great demo website byotplib)Source
Inspired by:
Remaining
totpSecretat rest using a symetric algorithm