RICH_TEXT_V2 upgrade command #9704
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a migration command to upgrade RICH_TEXT fields to a new RICH_TEXT_V2 composite structure, which stores both BlockNote JSON and Markdown representations of rich text content.
- Added
MigrateRichTextFieldCommandin/packages/twenty-server/src/database/commands/upgrade-version/0-41/0-41-migrate-rich-text-field.command.tsto handle field migration with BlockNote to Markdown conversion - Defined new
RICH_TEXT_V2composite type in/packages/twenty-server/src/engine/metadata-modules/field-metadata/composite-types/rich-text-v2.composite-type.tswith blocknote and markdown properties - Missing transaction wrapping and rollback mechanisms in migration process which could lead to data inconsistency if failures occur
- No validation or cleanup of old fields after migration is completed
- Row-by-row processing could impact performance with large datasets
8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| async executeActiveWorkspacesCommand( | ||
| passedParam: string[], | ||
| options: BaseCommandOptions, | ||
| workspaceIds: string[], | ||
| ): Promise<void> { |
There was a problem hiding this comment.
style: passedParam is unused in this implementation but passed through to migrateRichTextFieldCommand. Consider documenting the expected parameters or removing if not needed.
| for (const row of rows) { | ||
| const blocknoteFieldValue = row[richTextField.name]; | ||
| const markdownFieldValue = blocknoteFieldValue | ||
| ? await serverBlockNoteEditor.blocksToMarkdownLossy( | ||
| JSON.parse(blocknoteFieldValue), | ||
| ) | ||
| : null; |
There was a problem hiding this comment.
logic: No error handling for JSON.parse() - could throw exception and halt migration if blocknoteFieldValue contains invalid JSON
|
@eliasylonen I'm closing this PR for now as we have to merge first the backend PR, let's only open one PR at a time. |
What the upgrade command does:
RICH_TEXT_V2fieldsRICH_TEXTfields toRICH_TEXT_V2bodyV2view field position to match that of thebodyfield for each workspacePR #3 of this comment