Update trigger selection design #9717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reorganizes and enhances the workflow trigger selection system by introducing separate categories for database and manual triggers, with improved UI organization and clearer event naming.
- Introduced new constants in
/workflow-trigger/constants/DatabaseTriggerTypes.tsand/DatabaseTriggerEvents.tsto better organize trigger types and events - Added section titles 'Data' and 'Others' in
RightDrawerWorkflowSelectTriggerTypeContent.tsxfor improved trigger type categorization - Simplified trigger event handling in
WorkflowEditTriggerDatabaseEventForm.tsxby removing redundant event type selector - Fixed icon inconsistency in
DatabaseTriggerTypes.tswhereIconTrashis incorrectly used for record update events - Potential edge case in
getTriggerDefaultDefinition.tswhere event name could be undefined if no matching event is found
12 file(s) reviewed, 12 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -35,14 +44,37 @@ export const RightDrawerWorkflowSelectTriggerTypeContent = ({ | |||
|
|
|||
| return ( | |||
| <StyledActionListContainer> | |||
| {TRIGGER_TYPES.map((action) => ( | |||
| <StyledSectionTitle>Data</StyledSectionTitle> | |||
| {DATABASE_TRIGGER_TYPES.map((action) => ( | |||
There was a problem hiding this comment.
style: Duplicate onClick handler logic between DATABASE_TRIGGER_TYPES and OTHER_TRIGGER_TYPES. Consider extracting to a shared function.
...nt/src/modules/workflow/workflow-trigger/components/WorkflowEditTriggerDatabaseEventForm.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-diagram/utils/generateWorkflowDiagram.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerEvents.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerName.ts
Show resolved
Hide resolved
...nt/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultDefinition.test.ts
Show resolved
Hide resolved
...nt/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultDefinition.test.ts
Show resolved
Hide resolved
...ages/twenty-front/src/modules/workflow/workflow-trigger/utils/getTriggerDefaultDefinition.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-variables/utils/getTriggerStepName.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-variables/utils/getTriggerStepName.ts
Show resolved
Hide resolved
bosiraphael
reviewed
Jan 17, 2025
packages/twenty-front/src/modules/workflow/workflow-diagram/utils/generateWorkflowDiagram.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerTypes.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enregistrement.de.l.ecran.2025-01-17.a.15.07.12.mov