fix(session-storage): add typing and trust proxy setting #9725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added explicit typing for session storage options to improve type safety. Enabled 'trust proxy' to ensure proper client IP and protocol detection behind proxies. These changes improve security and reliability in session handling.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added explicit typing for session storage options and enabled trust proxy settings to improve security and reliability when running behind proxies, particularly for SSO functionality.
- Added
trust proxysetting inpackages/twenty-server/src/main.tsto ensure accurate client IP detection - Implemented explicit
session.SessionOptionstyping insession-storage.module-factory.tsfor better type safety - Set secure cookie option based on HTTPS detection through
SERVER_URLenvironment variable - Added Redis connection error handling with descriptive error messages
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+89
to
+90
| // Trust the first proxy to ensure correct client IP and protocol detection. | ||
| app.set('trust proxy', 1); |
There was a problem hiding this comment.
style: Ensure this is only enabled when actually running behind a proxy. Consider making this configurable via an environment variable.
Relocated the session middleware initialization to an earlier point in the code for better alignment and clarity. This change ensures proper setup and avoids redundancy in the middleware application.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Fix #9430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explicit typing for session storage options to improve type safety. Enabled 'trust proxy' to ensure proper client IP and protocol detection behind proxies. These changes improve security and reliability in session handling.