TECHEMPROD-1428 - Fix broken reference to TwilioClientOptions#542
TECHEMPROD-1428 - Fix broken reference to TwilioClientOptions#542dcanonmolina wants to merge 1 commit intotwilio-labs:mainfrom
Conversation
Starting Twilio NodeJS SDK version 4.0.0, the reference for TwilioClientOptions was removed. I included the right option: RequestClientOptions to fix the TS compiling process.
|
|
Hi @dcanonmolina, Thanks for submitting this fix for the I wanted to bring my related PR #541 to your attention, which addresses this same issue as part of a broader upgrade to Twilio SDK v5. In Twilio SDK v5, the primary options type for the client constructor appears to be Based on the changes in v5, Could the maintainers perhaps review PR #541 first? Merging it should resolve the underlying type issue that this PR (#542) aims to fix, potentially making this one redundant. Happy to discuss further! |
|
@mikefaille thanks! I'm going to withdraw my PR in favor of yours. |
Starting Twilio NodeJS SDK version 4.0.0, the reference for TwilioClientOptions was removed. I included the right option: RequestClientOptions to fix the TS compiling process.
Contributing to Twilio