Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: librarian time check #594

Merged
merged 11 commits into from
Aug 12, 2024
Merged

chore: librarian time check #594

merged 11 commits into from
Aug 12, 2024

Conversation

manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Jul 22, 2024 •
edited
Loading

Removing run_openapi_generator from for loop which was causing too much delay with pipelines

sbansla
sbansla reviewed Jul 29, 2024
View reviewed changes
scripts/build_twilio_library.py
if language in CLEANUP_IMPORT_LANGUAGES:
remove_unused_imports(output_path, language)
if language in REMOVE_DUPLICATE_IMPORT_LANGUAGES:
remove_duplicate_imports(output_path, language)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to create a different PR which has less commits. This PR has 9 commits.
Changes looks good, I have tested code is getting generated within 20 seconds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes 20 seconds because we are passing directory, If file is passed it takes more time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get approval from @AsabuHere as well.

sbansla
sbansla reviewed Jul 29, 2024
View reviewed changes
scripts/build_twilio_library.py
@@ -62,18 +74,17 @@ def generate_domain_for_language(spec_file: str, config_path: str, spec_folder:
'arrayItemSuffix': ''
},
}

# print(config)
with open(full_config_path, 'w') as f:
Copy link
Contributor

@sbansla sbansla Jul 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print can be removed.

AsabuHere
AsabuHere approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-php'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-ruby'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-java'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-node'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manisha1997 manisha1997 merged commit 65a9aa4 into main Aug 12, 2024
19 of 21 checks passed
@manisha1997 manisha1997 deleted the librarian-time branch August 12, 2024 07:11
AsabuHere pushed a commit that referenced this pull request Sep 20, 2024
@manisha1997 @AsabuHere
chore: librarian time check (#594)
e530477 
Removing run_openapi_generator from for loop which was causing too much
delay with pipelines
AsabuHere pushed a commit that referenced this pull request Sep 23, 2024
@manisha1997 @AsabuHere
chore: librarian time check (#594)
b9f4793 
Removing run_openapi_generator from for loop which was causing too much
delay with pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbansla sbansla sbansla left review comments

@AsabuHere AsabuHere AsabuHere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manisha1997 @AsabuHere @sbansla