Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding content v1 #613

Merged
merged 2 commits into from
Sep 24, 2024
Merged

chore: adding content v1 #613

merged 2 commits into from
Sep 24, 2024

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Sep 19, 2024

Adding content v1, as it is getting added to open-api with all content v1 apis (including json)

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@sbansla
Copy link
Contributor Author

sbansla commented Sep 19, 2024

Ruby failure is only due to diff of spaces.

Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sbansla sbansla merged commit 4e9d15a into main Sep 24, 2024
16 of 20 checks passed
@sbansla sbansla deleted the adding-content_v1 branch September 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants