Skip to content

Conversation

luisrivas
Copy link
Collaborator

No description provided.

Comment on lines 50 to 139
track.attach($activeVideo.get(0));
const videoElement = $activeVideo.get(0)
if(track.mediaStreamTrack) {
window.CitrixWebRTC.mapVideoElement(videoElement);
videoElement.srcObject = window.CitrixWebRTC.createMediaStream([track.mediaStreamTrack]);
} else {
track.attach($activeVideo.get(0));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call mapVideoElement right after attach instead? That way customer won't have to manually create a mediastream. Will this work?

const el = track.attach($activeVideo.get(0));
window.CitrixWebRTC.mapVideoElement(el);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your suggestion would make it cleaner. Unfortunately, it does not work.

@luisrivas luisrivas force-pushed the feature/webrtc-redirection branch from cc35a4d to 1452027 Compare March 13, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants