feat: support WebRTC redirections #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliesantos
requested changes
Feb 14, 2025
quickstart/src/joinroom.js
Outdated
Comment on lines
50
to
139
| track.attach($activeVideo.get(0)); | ||
| const videoElement = $activeVideo.get(0) | ||
| if(track.mediaStreamTrack) { | ||
| window.CitrixWebRTC.mapVideoElement(videoElement); | ||
| videoElement.srcObject = window.CitrixWebRTC.createMediaStream([track.mediaStreamTrack]); | ||
| } else { | ||
| track.attach($activeVideo.get(0)); | ||
| } |
There was a problem hiding this comment.
Can we call mapVideoElement right after attach instead? That way customer won't have to manually create a mediastream. Will this work?
const el = track.attach($activeVideo.get(0));
window.CitrixWebRTC.mapVideoElement(el);There was a problem hiding this comment.
Your suggestion would make it cleaner. Unfortunately, it does not work.
luisrivas
force-pushed
the
feature/webrtc-redirection
branch
from
cc35a4d to
1452027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.