Skip to content
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,7 @@ jobs:
python -I admin/check_tag_version_match.py "${{ github.ref }}"

- name: Publish to PyPI - on tag
# This was tag 1.9.0 on 2024-07-30
uses: pypa/gh-action-pypi-publish@ec4db0b4ddc65acdf4bff5fa45ac92d78b56bdf0
uses: pypa/gh-action-pypi-publish@release/v1


coverage:
Expand Down
43 changes: 43 additions & 0 deletions NEWS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,49 @@ Release notes

.. towncrier release notes start

towncrier 25.8.0rc2 (2025-08-15)
================================

Features
--------

- Support was added for Mercurial SCM. (`#394 <https://github.com/twisted/towncrier/issues/394>`_)
- The `towncrier check` command now has a `--staged` flag to inspect the files staged for commit when checking for a news fragment: useful in a pre-commit hook (`#676 <https://github.com/twisted/towncrier/issues/676>`_)
- When used with an `pyproject.toml` file, when no explicit values are
defined for [tool.towncrier.name|package] they will now fallback to
the value of [project.name]. (`#687 <https://github.com/twisted/towncrier/issues/687>`_)
- More simple configuration for Keep a Changelog style changelogs (`#691 <https://github.com/twisted/towncrier/issues/691>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry isn't very clear from the PoV of an end-user. Reading it in the change log, I don't understand what the effect is for me.

- Added support for Python 3.13 and removed support for Python 3.8. (`#700 <https://github.com/twisted/towncrier/issues/700>`_)


Bugfixes
--------

- Multi-line newsfragments that ends with a code block will now have a newline inserted before appending the link to the issue, to avoid breaking formatting. (`#614 <https://github.com/twisted/towncrier/issues/614>`_)
- Markdown header level is correctly inferred from ``title_format``. (`#695 <https://github.com/twisted/towncrier/issues/695>`_)


Improved Documentation
----------------------

- The documentation RST source files are now included in the sdist package. (`#672 <https://github.com/twisted/towncrier/issues/672>`_)
- Refactor the default markdown template to make it easier to understand, extend, and customize. (`#706 <https://github.com/twisted/towncrier/issues/706>`_)


Deprecations and Removals
-------------------------

- When no sections are present,
the default Markdown template now renders the category headers as H2.
In previous versions it was rendered as H3. (`#663 <https://github.com/twisted/towncrier/issues/663>`_)
Comment on lines +46 to +48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this entry be under removals it's a feature / behavior change if you ask me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a better name for Deprecations and Removals ... basically.
under Deprecations and Removals we have any "breaking changes"

We can look to update the template and use "Breaking changes"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adiroiban yeah, I should probably propose updating the default templates. Over at @aio-libs and in other projects, I ended up having more accurate categories like contrib/packaging/downstream: https://yarl.aio-libs.org/en/latest/changes/#id100 / https://yarl.aio-libs.org/en/latest/contributing/guidelines/#alright-so-how-to-add-a-news-fragment / https://github.com/aio-libs/yarl/blob/b8d06ec9a7d95ac11437afd5e467c2c2bb1704d2/towncrier.toml#L18-L68.

Though, I wouldn't consider this all a part of the release PR. It's probably best to postpone until post-release.



Misc
----

- `#667 <https://github.com/twisted/towncrier/issues/667>`_, `#669 <https://github.com/twisted/towncrier/issues/669>`_, `#679 <https://github.com/twisted/towncrier/issues/679>`_, `#680 <https://github.com/twisted/towncrier/issues/680>`_, `#682 <https://github.com/twisted/towncrier/issues/682>`_, `#701 <https://github.com/twisted/towncrier/issues/701>`_, `#702 <https://github.com/twisted/towncrier/issues/702>`_, `#713 <https://github.com/twisted/towncrier/issues/713>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be a single bullet point?

Suggested change
- `#667 <https://github.com/twisted/towncrier/issues/667>`_, `#669 <https://github.com/twisted/towncrier/issues/669>`_, `#679 <https://github.com/twisted/towncrier/issues/679>`_, `#680 <https://github.com/twisted/towncrier/issues/680>`_, `#682 <https://github.com/twisted/towncrier/issues/682>`_, `#701 <https://github.com/twisted/towncrier/issues/701>`_, `#702 <https://github.com/twisted/towncrier/issues/702>`_, `#713 <https://github.com/twisted/towncrier/issues/713>`_
`#667 <https://github.com/twisted/towncrier/issues/667>`_, `#669 <https://github.com/twisted/towncrier/issues/669>`_, `#679 <https://github.com/twisted/towncrier/issues/679>`_, `#680 <https://github.com/twisted/towncrier/issues/680>`_, `#682 <https://github.com/twisted/towncrier/issues/682>`_, `#701 <https://github.com/twisted/towncrier/issues/701>`_, `#702 <https://github.com/twisted/towncrier/issues/702>`_, `#713 <https://github.com/twisted/towncrier/issues/713>`_.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it's implemented now in the template and is how we did it in the past


the ".misc" items might not have a description

Now... if you ask me, I would say that we should not list these items at all in the release notes


But this is a discussion for a separate issue/PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This is separate. Though, I feel like misc items should be rendered with content, just like the others. If something isn't necessary in the change log, it should just not have a note to begin with.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the .misc notes. ... but I agree they should not be rendered.

They are an explicit confirmation that the changes are not public.

It makes it easier to raise an errror in the case you accidentally forget to update the release notes for a public change.


We can look into this as part of updating the template that we user towncrier

We don't have to change the default template , towncrier can have a custom template ... but I think that it makese sense for towncrier itself to use the default template

I am happy to update the default template... but in a separate issue



Towncrier 24.8.0 (2024-08-23)
=============================

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ name = "towncrier"
# For RC - 23.11.0rc1 (release candidate starts at 1)
# For final - 23.11.0
# make sure to follow PEP440
version = "24.8.0.dev0"
version = "25.8.0rc2"
description = "Building newsfiles for your project."
readme = "README.rst"
license = "MIT"
Expand Down
1 change: 0 additions & 1 deletion src/towncrier/newsfragments/394.feature.rst

This file was deleted.

1 change: 0 additions & 1 deletion src/towncrier/newsfragments/614.bugfix.rst

This file was deleted.

3 changes: 0 additions & 3 deletions src/towncrier/newsfragments/663.removal

This file was deleted.

Empty file.
Empty file.
1 change: 0 additions & 1 deletion src/towncrier/newsfragments/672.doc

This file was deleted.

1 change: 0 additions & 1 deletion src/towncrier/newsfragments/676.feature.rst

This file was deleted.

Empty file.
Empty file.
Empty file.
3 changes: 0 additions & 3 deletions src/towncrier/newsfragments/687.feature.rst

This file was deleted.

1 change: 0 additions & 1 deletion src/towncrier/newsfragments/691.feature.rst

This file was deleted.

1 change: 0 additions & 1 deletion src/towncrier/newsfragments/695.bugfix.rst

This file was deleted.

1 change: 0 additions & 1 deletion src/towncrier/newsfragments/700.feature.rst

This file was deleted.

Empty file.
1 change: 0 additions & 1 deletion src/towncrier/newsfragments/702.misc.rst

This file was deleted.

1 change: 0 additions & 1 deletion src/towncrier/newsfragments/706.doc

This file was deleted.

Empty file.
Loading