Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored rank-specific logger #120

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

1darshanpatil
Copy link

@1darshanpatil 1darshanpatil commented Apr 2, 2023

#Refactored rank_specific functions.
#Implemented the logic without changing the behavior.
#The readability and maintainability of the code improved.

Tested against:
test_torch_logging.py

#Refactored rank_specific functions.
#Implemented the logic without changing the behavior.
#The readability and maintainability of the code improved.
-------------------------
Tested against:
test_torch_logging.py
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2023

CLA assistant check
All committers have signed the CLA.

optimizer selection logic for improved readability and maintainability.
used the any function to short-circuit the loop as soon as an empty tensor is found.
@1darshanpatil
Copy link
Author

used the any function to short-circuit the loop as soon as an empty tensor is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants