fix: parser improvements for v0.0.40 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add visibility modifier support for method definitions: - Parse `private def`, `protected def`, `public def` syntax - Extract visibility info and include in parse result - Preserve visibility keywords during type erasure - Add VISIBILITY_PATTERN constant for reuse Fixes #17
Add HeredocDetector to identify heredoc regions and skip them during parsing. This prevents def patterns inside heredoc from being incorrectly recognized as method definitions. - Add HeredocDetector class with detect() and inside_heredoc?() methods - Support <<DELIM, <<-DELIM, <<~DELIM, <<'DELIM', <<"DELIM" syntax - Integrate heredoc detection in Parser.parse() - Add comprehensive tests for HeredocDetector Fixes #18
Add private/protected visibility prefix to generated RBS method signatures. Both TRuby::RBSGenerator and TRuby::IR::RBSGenerator now output correct RBS format like 'private def method: () -> Type'. Related to #17
- Pass visibility from parser to IR MethodDef nodes - Add private prefix to RBS output (RBS doesn't support protected) - Add E2E tests for visibility in RBS and compiled Ruby - Update unit tests for RBS generator visibility handling RBS only supports private, not protected (ruby/rbs#579) Related to #17
Extend HeredocDetector to also detect Ruby block comments. Parser now correctly ignores def patterns inside =begin/=end blocks. Related to #18
Remove legacy components that are no longer needed: - Remove TRuby::RBSGenerator (use IR::RBSGenerator) - Remove LegacyCompiler class - Remove LegacyParser class - Remove use_ir parameter from Compiler (always use IR) - Remove use_combinator parameter from Parser (always enabled) This simplifies the codebase by eliminating dual-path maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parser improvements and legacy code removal based on Reddit feedback
Issues Fixed
private def,protected def,public defsyntax parsing=begin/=endblock commentsRBS Generation Improvements
private def→private defin RBS)Legacy Code Removal
TRuby::RBSGenerator(usingIR::RBSGenerator)LegacyCompiler,LegacyParserclassesuse_ir,use_combinatorparameters (always use IR)Test plan
parser_spec.rb)heredoc_detector_spec.rb)type_erasure_spec.rb)class_rbs_generation_spec.rb)Closes #17, Closes #18, Closes #21