Merged
Conversation
an initial draft was named lucy
There was a problem hiding this comment.
Pull request overview
Updates the test suite to align naming literals with the loosey project name and adds a guard test to ensure generated SQL stays consistent across internal dialect packages.
Changes:
- Add a test ensuring each
internal/*/schema.sqlis included verbatim within the correspondingqueries.sql. - Rename integration test container DB/user/password literals from
lucy*toloosey*. - Adjust
gooseytest helper/comment wording (and remove at.Helper()call).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| provider_test.go | Adds a cross-package SQL consistency test (schema.sql must be a substring of queries.sql). |
| internal/integrations/pgx/integration_test.go | Renames Postgres testcontainer database/user/password literals to loosey*. |
| internal/integrations/mysql/integration_test.go | Renames MariaDB testcontainer database/user/password literals to loosey*. |
| goosey/goosey.go | Removes t.Helper() from the Run test helper. |
| goosey/compat.go | Updates log/error strings and comments from lucy to loosey. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crhntr
force-pushed
the
chore/clean-up-tests-and-some-name-literals
branch
from
dd70acf to
6160615
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crhntr
force-pushed
the
chore/clean-up-tests-and-some-name-literals
branch
from
6160615 to
f7b50aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.