Skip to content

refactor: move claude settings to .config#50

Merged
crhntr merged 1 commit intomainfrom
chore/move-claude-to-config
Dec 4, 2025
Merged

refactor: move claude settings to .config#50
crhntr merged 1 commit intomainfrom
chore/move-claude-to-config

Conversation

@crhntr
Copy link
Copy Markdown
Member

@crhntr crhntr commented Dec 4, 2025

No description provided.

@crhntr crhntr merged commit 4b418a8 into main Dec 4, 2025
2 checks passed
@crhntr crhntr deleted the chore/move-claude-to-config branch December 4, 2025 10:46
@claude
Copy link
Copy Markdown

claude Bot commented Dec 4, 2025

Code Review: Refactor Claude Settings Location

Summary

This PR moves the Claude settings file from .claude/settings.json to .config/.claude/settings.json. This is a simple file relocation with no code changes.

✅ Positive Aspects

  • Clean refactor: This is a pure file move with no modifications to the settings content
  • Organizational improvement: Moving Claude configuration to .config/ follows common conventions for configuration files

⚠️ Issues Found

1. Incomplete Migration - .gitignore Not Updated

Severity: High

The .gitignore file still references the old path at line 26:

.claude/settings.local.json

This should be updated to:

.config/.claude/settings.local.json

Impact: Local settings files may not be properly ignored after this change, potentially causing developers to accidentally commit sensitive local configuration.

Location: .gitignore:26

2. Documentation Not Updated

Severity: Medium

The project documentation does not appear to reference the Claude settings location explicitly, but it is worth verifying:

  • GitHub workflow files (.github/workflows/claude.yml and .github/workflows/claude-code-review.yml) reference Claude documentation but do not hardcode paths
  • No references found in Claude.md or other docs

However, if there are any README files, getting started guides, or developer documentation that mention where Claude settings are stored, those should be updated as well.

Recommendations

  1. Update .gitignore: Change .claude/settings.local.json to .config/.claude/settings.local.json
  2. Verify no hardcoded paths: Search the codebase for any hardcoded references to .claude/ that might break
  3. Consider backwards compatibility: If external tools or developer workflows depend on the old location, consider:
    • Adding a note in the commit message or PR description about this breaking change
    • Creating a migration guide for developers
    • Possibly supporting both locations temporarily with a deprecation notice

Testing Checklist

  • Verify Claude Code can find settings at the new location
  • Confirm settings.local.json is properly ignored in the new location
  • Test that existing workflows continue to function

Conclusion

This is a reasonable refactoring, but it is incomplete without updating .gitignore. The missing .gitignore update is a critical omission that could lead to accidental commits of local settings.

Recommendation: Request changes to update .gitignore before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant