Order.fromComparable Method Signature Change to Allow java.sql.Date
#4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ikeyan , thank you for the PR, it can be helpful indeed! |
|
@satorg I added a test in OrderSuite.scala |
satorg
approved these changes
Apr 8, 2025
johnynek
approved these changes
Apr 10, 2025
johnynek
reviewed
Apr 10, 2025
| def fromComparable[A <: Comparable[A]]: Order[A] = _ compareTo _ | ||
| private type ContravariantComparable[A] = Comparable[? >: A] | ||
|
|
||
| def fromComparable[A <: ContravariantComparable[A]]: Order[A] = _ compareTo _ |
There was a problem hiding this comment.
seems to me like this should be implicit potentially, perhaps at a lower priority.
There was a problem hiding this comment.
@johnynek if an implicit parameter is added, would that break binary compatibility?
There was a problem hiding this comment.
I don't mean an implicit parameter, I mean implicit def from comparable...
This won't break JVM binary compatibility. But maybe we need to lower the priority of this implicit by putting it in a trait and extending here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Order.fromComparablemethod signature inOrder.scalahas been modified to allow it to acceptjava.sql.Date.This change enables the method to work with types such as
java.sql.Dateand other subtypes ofjava.util.Datewhich implementsComparable<java.util.Date>.