-
Notifications
You must be signed in to change notification settings - Fork 3
Fix: vitest ignore node_modules #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 npm run test
works fine for me from this package's directory:
joshgoldberg ~/repos/typescript-eslint-examples/packages/eslint-plugin-example-typed-linting $ npm run test
> [email protected] test
> vitest
The CJS build of Vite's Node API is deprecated. See https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
DEV v2.1.8 /Users/josh/repos/typescript-eslint-examples/packages/eslint-plugin-example-typed-linting
✓ src/rules/no-loop-over-enum.test.ts (6) 769ms
✓ no-loop-over-enum (6) 769ms
✓ valid (5) 763ms
✓ enum Values {} 732ms
✓ for (const a in []) {}
✓ for (const a of []) {}
✓
const values = {};
for (const a in values) {}
✓
const values = [];
for (const a of values) {}
✓ invalid (1)
✓
enum Values {}
for (const a in Values) {}
Test Files 1 passed (1)
Tests 6 passed (6)
Start at 10:14:46
Duration 1.54s (transform 25ms, setup 0ms, collect 612ms, tests 769ms, environment 0ms, prepare 33ms)
PASS Waiting for file changes...
press h to show help, press q to quit
What command(s) are you running, and what are the outputs?
Solved by #15 🤷♂️ Don't know why, but running this on 494b18c reproduced the error:
With the latest commit (0366be0) it works. |
🤷 glad it worked out haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this project must be run with all packages together, but when I tried to run only specific package on its own folder, I needed to ignore the "node_modules" folder.