test: URL encoded Ids

typesense · Aug 29, 2024 · 52596d6 · 52596d6
1 parent 2b44d9d
commit 52596d6
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 6 deletions.
diff --git a/test/Typesense/Alias.spec.js b/test/Typesense/Alias.spec.js
@@ -36,14 +36,14 @@ describe("Alias", function () {
         .onGet(
           apiCall.uriFor(
             "/aliases/companies",
-            typesense.configuration.nodes[0]
+            typesense.configuration.nodes[0],
           ),
           null,
           {
             Accept: "application/json, text/plain, */*",
             "Content-Type": "application/json",
             "X-TYPESENSE-API-KEY": typesense.configuration.apiKey,
-          }
+          },
         )
         .reply(200, "{}", {
           "content-type": "application/json; charset=utf-8",
@@ -55,6 +55,28 @@ describe("Alias", function () {
 
       expect(returnData).to.eventually.deep.equal({}).notify(done);
     });
+
+    it("retrieves the alias with URL encoded name", function (done) {
+      mockAxios
+        .onGet(
+          apiCall.uriFor(
+            "/aliases/abc123%20%2F%3A%3D-_~%26%3F%23",
+            typesense.configuration.nodes[0],
+          ),
+          null,
+          {
+            Accept: "application/json, text/plain, */*",
+            "Content-Type": "application/json",
+            "X-TYPESENSE-API-KEY": typesense.configuration.apiKey,
+          },
+        )
+        .reply(200, "{}", {
+          "content-type": "application/json; charset=utf-8",
+        });
+      let returnData = typesense.aliases("abc123 /:=-_~&?#").retrieve();
+
+      expect(returnData).to.eventually.deep.equal({}).notify(done);
+    });
   });
 
   describe(".delete", function () {
@@ -63,14 +85,14 @@ describe("Alias", function () {
         .onDelete(
           apiCall.uriFor(
             "/aliases/companies",
-            typesense.configuration.nodes[0]
+            typesense.configuration.nodes[0],
           ),
           null,
           {
             Accept: "application/json, text/plain, */*",
             "Content-Type": "application/json",
             "X-TYPESENSE-API-KEY": typesense.configuration.apiKey,
-          }
+          },
         )
         .reply(200, "{}", {
           "content-type": "application/json; charset=utf-8",

diff --git a/test/Typesense/Aliases.spec.js b/test/Typesense/Aliases.spec.js
@@ -42,7 +42,7 @@ describe("Aliases", function () {
             Accept: "application/json, text/plain, */*",
             "Content-Type": "application/json",
             "X-TYPESENSE-API-KEY": typesense.configuration.apiKey,
-          }
+          },
         )
         .reply(201, "{}", {
           "content-type": "application/json; charset=utf-8",
@@ -54,6 +54,33 @@ describe("Aliases", function () {
 
       expect(returnData).to.eventually.deep.equal({}).notify(done);
     });
+
+    it("upserts an alias with URL encoded name", function (done) {
+      mockAxios
+        .onPut(
+          apiCall.uriFor(
+            "/aliases/abc123%20%2F%3A%3D-_~%26%3F%23",
+            typesense.configuration.nodes[0],
+          ),
+          {
+            collection_name: "books_january",
+          },
+          {
+            Accept: "application/json, text/plain, */*",
+            "Content-Type": "application/json",
+            "X-TYPESENSE-API-KEY": typesense.configuration.apiKey,
+          },
+        )
+        .reply(201, "{}", {
+          "content-type": "application/json; charset=utf-8",
+        });
+
+      let returnData = aliases.upsert("abc123 /:=-_~&?#", {
+        collection_name: "books_january",
+      });
+
+      expect(returnData).to.eventually.deep.equal({}).notify(done);
+    });
   });
 
   describe(".retrieve", function () {
@@ -66,7 +93,7 @@ describe("Aliases", function () {
             Accept: "application/json, text/plain, */*",
             "Content-Type": "application/json",
             "X-TYPESENSE-API-KEY": typesense.configuration.apiKey,
-          }
+          },
         )
         .reply(200, "[]", {
           "content-type": "application/json; charset=utf-8",