Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documented pagination #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dotnetCarpenter
Copy link

It took me a good while to find and figure out pagination (especially because the documentation is written in an upstream project repository).

This PR rectify this and put the pagination documentation right in the guide (with a link to the source documentation).

I hope this helps others ;>)

@dotnetCarpenter
Copy link
Author

Hallo @typicode, could you find the time to merge this PR? This should fix #65.

@dotnetCarpenter
Copy link
Author

Seems my PR is so old that it got out of sync with the master branch. I will rebase and force push.

@dotnetCarpenter
Copy link
Author

@jelenamilanovic I have rebased my PR to master, so you can merge it now :)

@jelenamilanovic
Copy link

@dotnetCarpenter, unfortunately, I don't have writing access to the repo. By approving your PR, I just wanted to raise awareness that your changes are correct and really useful - they helped me a lot with the task I was doing.

@typicode, can you, please, merge these changes so the others could benefit from them?

@ClarkAllen1556
Copy link

It took me awhile as well to find out if pagination was possible. Couldn't find it in the documentation. That's @dotnetCarpenter for making this PR it helped out a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants