Removal of conditionals before every debug output#1750
Open
khReichel wants to merge 1 commit intotzapu:masterfrom
Open
Removal of conditionals before every debug output#1750khReichel wants to merge 1 commit intotzapu:masterfrom
khReichel wants to merge 1 commit intotzapu:masterfrom
Conversation
Removal of redundant compiler conditionals before each debug output. The conditionals remained at code positions that had further functionality in addition to the debug output
Collaborator
|
Why? |
Author
|
Because there has been a ticket for that taks, right? |
Collaborator
|
I tried testing this in the min size branch, and I could not confirm that the compiler was not still allocating flash strings. |
Author
|
hmm.. I do not find any requirement about allocating flash strings in the ticket? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of redundant compiler conditionals before each debug output.
The conditionals remained at code positions that had further functionality in addition to the debug output