Fix watchdog timeout on esp32 when config portal is active#1818
Open
h2zero wants to merge 1 commit intotzapu:masterfrom
Open
Fix watchdog timeout on esp32 when config portal is active#1818h2zero wants to merge 1 commit intotzapu:masterfrom
h2zero wants to merge 1 commit intotzapu:masterfrom
Conversation
Calling `yield()` on the esp32 doesn't let the idle task run and therefore doesn't feed the watchdog. Instead, calling `delay(1)` forces the context change and allows the idle task to run.
Contributor
|
Huh, I never knew this was a thing: https://esp32.com/viewtopic.php?t=809#p3442 I always assumed that yield() fed the watchdog/allowed all pending tasks to run, not just higher priority ones. Go figure. |
Author
|
Yep, just like yielding when driving, don't need to stop if nobody else has the right of way. Funny that this hasn't been merged or commented on at least until now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
yield()on the esp32 doesn't let the idle task run and therefore doesn't feed the watchdog. Instead, callingdelay(1)forces the context change and allows the idle task to run.