Skip to content

Gps (please elaborate on this PR)#2

Open
rrhan0 wants to merge 8 commits intomasterfrom
gps
Open

Gps (please elaborate on this PR)#2
rrhan0 wants to merge 8 commits intomasterfrom
gps

Conversation

@rrhan0
Copy link
Copy Markdown

@rrhan0 rrhan0 commented Jun 12, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves # (issue)

Type of change

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Desmos calculations visualising the calculations https://www.desmos.com/calculator/i5oc1lgnfw
  • Plotting points on map with print_gps_corners(290, 38.31471488011587, -76.54638594373999, 25).
    38.31462717229391, -76.54653743553378
    38.314858788822505, -76.5464304366409
    38.314802587740864, -76.5462344519462
    38.31457097138882, -76.54634145083908
image

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ramjayakumar21 ramjayakumar21 changed the title Gps Gps (please elaborate on this PR) Sep 28, 2024
@ramjayakumar21
Copy link
Copy Markdown

@rrhan0 what is this PR for?

@rrhan0
Copy link
Copy Markdown
Author

rrhan0 commented Sep 28, 2024

@rrhan0 what is this PR for?

You merged it into suas-2024 already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants