Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fx.ShutdownError option #996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abramlab
Copy link

@abramlab abramlab commented Dec 7, 2022

Adds the fx.ShutdownError option, to be able to pass a custom error to Shutdowner and retrieve it from the application as the reason it shutdown.

Refers #672

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022

CLA assistant check
All committers have signed the CLA.

@jasonmills
Copy link
Contributor

@abramlab can you rebase this PR to make sure there aren't any conflicts against the latest changes to the shutdown and signal logic: b379e13

@abramlab
Copy link
Author

abramlab commented Dec 9, 2022

@abramlab can you rebase this PR to make sure there aren't any conflicts against the latest changes to the shutdown and signal logic: b379e13

Rebase done

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #996 (bbd8c2a) into master (ed3eef5) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head bbd8c2a differs from pull request most recent head a285dde. Consider uploading reports for the commit a285dde to get more accurate results

@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
- Coverage   98.09%   98.04%   -0.05%     
==========================================
  Files          39       39              
  Lines        1995     1996       +1     
==========================================
  Hits         1957     1957              
- Misses         30       31       +1     
  Partials        8        8              
Impacted Files Coverage Δ
shutdown.go 100.00% <100.00%> (ø)
annotated.go 99.00% <0.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abramlab abramlab force-pushed the shutdown-error-option branch 3 times, most recently from 4d26279 to 0778cf0 Compare December 16, 2022 20:53
@abramlab
Copy link
Author

@jasonmills what else is needed to merge the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants