Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier support for multiple instances locally #6289

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Easier support for multiple instances locally #6289

merged 3 commits into from
Sep 20, 2024

Conversation

jakobht
Copy link
Contributor

@jakobht jakobht commented Sep 17, 2024

What changed?

  • Make ports in development config configurable, so we can start several instances of the same service.
    • We keep the old defaults, so if nothing is specified everything works as before
  • Added script that starts several instances of the services, mainly for illustrative purposes, but could be useful to quickly start 3 instances of each of frontend, history and matching.

Why?

  • As we want to test things related to sharing we need to be able to have multiple instances of the services running, this enables this.

How did you test it?
Ran locally, this is just a development setup

Potential risks
None

Release notes

Documentation Changes

@jakobht
Make ports configurable, so we can start several instances of the sam…
33f4d1c 
…e service.

We keep the old defaults, so if nothing is specified everything works as before
@jakobht
Added script that starts several instances of the services, mainly fo…
82c00c1 
…r illustrative purposes, but could be useful to quickly start.
@jakobht jakobht changed the title Multi instance Easier support for multiple instances locally Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (b41976a) to head (d6eb461).
Report is 9 commits behind head on master.

Additional details and impacted files

see 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41976a...d6eb461. Read the comment docs.

taylanisikdemir
taylanisikdemir reviewed Sep 17, 2024
View reviewed changes
scripts/run_several_instances.sh
@@ -0,0 +1,29 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a script to stop all these binaries would be nice too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the script so ctrl-c will kill all the services. So now we can run the script, and if we just want to kill everything we just do ctrl-c and everything will be instantly killed.

@jakobht jakobht merged commit c8abc2a into uber:master Sep 20, 2024
20 checks passed
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Sep 26, 2024
@jakobht @dkrotx
Easier support for multiple instances locally (uber#6289)
868e2fd 
* Make ports configurable, so we can start several instances of the same service.

We keep the old defaults, so if nothing is specified everything works as before

* Added script that starts several instances of the services, mainly for illustrative purposes, but could be useful to quickly start.

* The services are now killed on ctrl-c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobht @taylanisikdemir