Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rolling window QPS tracker #6295

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add rolling window QPS tracker #6295

merged 1 commit into from
Sep 24, 2024

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Sep 19, 2024

What changed?
Add rolling window QPS tracker

Why?
Rolling window QPS tracker is more responsive and accurate but doesn't smooth fluctuations. We will compare it with EMAFixedWindowQPS tracker to see which is more suitable for our use case.

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (dc51527) to head (a532b47).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
common/stats/stats.go 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
common/stats/stats.go 90.90% <90.90%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 811ffe7...a532b47. Read the comment docs.

@Shaddoll Shaddoll merged commit a6e62ee into uber:master Sep 24, 2024
22 checks passed
@Shaddoll Shaddoll deleted the qps branch September 24, 2024 20:00
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants