Fix: Fix GitHub Issue #1071: Add edgeToVertexes function **Issue Description:** It would be handy to hav... #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
isaacbrodsky
requested review from
ajfriend,
dfellis,
dmitryzv,
isaacbrodsky and
nrabinowitz
isaacbrodsky
reviewed
Nov 7, 2025
Collaborator
isaacbrodsky
left a comment
isaacbrodsky
left a comment
There was a problem hiding this comment.
As our CI enforces code formatting, please rebuild with clang-format-14 and CMake option ENABLE_FORMATTING=ON. This will automatically apply formatting to all files.
Comment on lines
+313
to
+315
| if (originResult) { | ||
| return originResult; | ||
| } |
Collaborator
There was a problem hiding this comment.
All other error cases but the initial one are uncovered. Maybe they can be marked NEVER, which we use to mark error cases that should not be reachable by any condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent: blackbox
Model: blackboxai/blackbox-pro