Independence from custom urdfdom#32
Merged
rhaschke merged 3 commits intomelodic-develfrom Jun 23, 2024
Merged
Conversation
75447ad to
c1c6dfb
Compare
This makes urdf_tactile independent from a custom urdfdom.
dde4662 to
3cc8336
Compare
c1c6dfb to
e947cea
Compare
e947cea to
294b71c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major refactoring to get independent from custom changes to upstream packages (ros/urdfdom#84, ros/urdf#5).
Essentially, we drop the idea to use plugins, but parser our tactile
<sensor>tags directly.