-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Add WiFi more reliable #250
Open
zytegalaxy
wants to merge
8
commits into
main
Choose a base branch
from
wifi-unavailable-exception-handle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sassanh
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good. Three suggestions:
- It makes the code base crowded to have a
_with_retry
version of some functions, so we need to either make the original function always retry (remove_with_retry
and move the decorator to the original function) or retry when calling the function, using thetenacity.Retrying
function like this I think the latter is the best way to go as it is more explicit and less opinionated. - Lint commits and some other commits don’t have value by themselves, I suggest squashing all commits of this pull request into a single
refactor(wifi): improve resilience of wifi service by retrying week points if they fail
or something like that. It helps keeping our git log stay clean. You can do it by soft resetting to the parent commit of this branch, and then do a single commit and force-pushing it. - Add the commit message to the
Upcoming
section of the change log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #247
add_wifi_connection
fails withsdbus_async.networkmanager.exceptions.NetworkManagerUnknownConnectionError
exception.