-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new indeterminated progress design #958
Conversation
it looks really good! awesome transition!!! I wonder if it would be doable to enable/disable the dots showing up? maybe without the dots/discs it would be a good default because our theme is also used in the ubuntu flavours and it somehow "hardcodes" the ubuntu logo into it? Maybe this is overthinking I dont know |
Argh, I didn't thought about this.... :/ |
yes with the platform plugin I use in the inherited theme, but instead I would just make the dots optional and default to the look we have here |
@Feichtmeier I think it is a bad idea to change the design depending on the platform. Technically it would have been nice, but it would have caused sizing problems: the dots make the widget a bit bigger. I did a similar, but simpler, design without dots: Capture.video.du.2024-12-03.15-57-58.mp4This is also better because the GTK version doesn't have dots, so it would have looked weird to have dots in Flutter. |
is it rdy to merge? or do you want to wait until this is in gtk ? |
I need to cleanup the code a little bit, then we can merge :) |
test |
Okay, now it works. @Feichtmeier you can review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, LGTM!
Capture.video.du.2024-11-06.00-28-34.webm
Note: the determinate linear progress is too big, it's a side effect I need to fix but don't take attention on that. I also need to add an initial animation to the linear undetermined animation
@Feichtmeier You can give me feedback by testing this branch :)