Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new indeterminated progress design #958

Merged
merged 12 commits into from
Dec 3, 2024

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Nov 5, 2024

Capture.video.du.2024-11-06.00-28-34.webm

Note: the determinate linear progress is too big, it's a side effect I need to fix but don't take attention on that. I also need to add an initial animation to the linear undetermined animation

@Feichtmeier You can give me feedback by testing this branch :)

@Jupi007 Jupi007 added the widgets label Nov 5, 2024
@Feichtmeier
Copy link
Member

it looks really good! awesome transition!!!

I wonder if it would be doable to enable/disable the dots showing up? maybe without the dots/discs it would be a good default because our theme is also used in the ubuntu flavours and it somehow "hardcodes" the ubuntu logo into it? Maybe this is overthinking I dont know

@Jupi007
Copy link
Member Author

Jupi007 commented Nov 6, 2024

Argh, I didn't thought about this.... :/
Do we provide a way to detect ubuntu flavor in yaru? I don't remember...

@Feichtmeier
Copy link
Member

Argh, I didn't thought about this.... :/ Do we provide a way to detect ubuntu flavor in yaru? I don't remember...

yes with the platform plugin I use in the inherited theme, but instead I would just make the dots optional and default to the look we have here
ubuntu/yaru#4160

@Jupi007
Copy link
Member Author

Jupi007 commented Dec 3, 2024

@Feichtmeier I think it is a bad idea to change the design depending on the platform. Technically it would have been nice, but it would have caused sizing problems: the dots make the widget a bit bigger.

I did a similar, but simpler, design without dots:

Capture.video.du.2024-12-03.15-57-58.mp4

This is also better because the GTK version doesn't have dots, so it would have looked weird to have dots in Flutter.

@Feichtmeier
Copy link
Member

is it rdy to merge? or do you want to wait until this is in gtk ?

@Jupi007
Copy link
Member Author

Jupi007 commented Dec 3, 2024

I need to cleanup the code a little bit, then we can merge :)

@Feichtmeier
Copy link
Member

test

@Jupi007 Jupi007 marked this pull request as ready for review December 3, 2024 20:10
@Jupi007
Copy link
Member Author

Jupi007 commented Dec 3, 2024

Okay, now it works. @Feichtmeier you can review and merge.
The golden tests only fail cause to the windows controls PR.

Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, LGTM!

@Feichtmeier Feichtmeier merged commit c8c094d into ubuntu:main Dec 3, 2024
6 of 7 checks passed
@Jupi007 Jupi007 deleted the progress-new-design branch December 3, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants