Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some smaller square icons #4190

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Some smaller square icons #4190

merged 5 commits into from
Feb 27, 2025

Conversation

ubuntujaggers
Copy link
Contributor

Hi everyone,

This is seeking to address #4163. I can either add the rest of the icons to this branch before we merge it, or we can just do multiple PRs to merge icons that are ready (assuming that people are happy with the new icons!).

The full size icon is still slightly bigger than I would like, because I would have liked the length of each side to be exactly halfway between the short and long sides of an oblong. Since the oblongs are 224 x 176, that would have meant a square of size 200 x 200. Unfortunately, when scaled to app grid size, 200px didn't shrink down to a whole number of pixels, meaning there was anti-aliasing round the edges. I've gone for 208 x 208px squares which are still noticeably smaller but render perfectly crisply on the app grid.

image

image

The revised icons in this branch (so far!) are as follows:

transmission
sudoku-app
tweaks-app
accessories-character-map
weather-app
wine
winetricks
session-properties
calculator-app
screenshot-app

@Feichtmeier
Copy link
Member

@3v1n0 @Muqtxdir it looks to be that our GitHub actions are somehow failing because they are outdated. Could you take a look so this PR can be merged?

@Muqtxdir
Copy link
Member

@Feichtmeier apologies, seeing this now - the issue was a missing dep in build ci. added it and updated this branch and looks like that fixed it

@Feichtmeier
Copy link
Member

Awesome 😎
I didn't see that the branch was out of date we should add this to pull requests as required

@3v1n0
Copy link
Contributor

3v1n0 commented Feb 23, 2025

Are the icons good to go?

Copy link
Member

@Muqtxdir Muqtxdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this @ubuntujaggers

@Muqtxdir Muqtxdir requested a review from Jupi007 February 23, 2025 17:11
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @ubuntujaggers !

Just a little nitpick, the button on the backdrop window is shifted on the new version of session-properties:

image

@ubuntujaggers
Copy link
Contributor Author

Great spot @Jupi007 - I'll fix it asap 🙂

@ubuntujaggers
Copy link
Contributor Author

Fixed it!

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, LGTM 👍

@Muqtxdir Muqtxdir merged commit e9a7fdc into master Feb 27, 2025
3 of 4 checks passed
@Muqtxdir Muqtxdir deleted the smaller-square-icons branch February 27, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants