-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some smaller square icons #4190
Conversation
@Feichtmeier apologies, seeing this now - the issue was a missing dep in build ci. added it and updated this branch and looks like that fixed it |
Awesome 😎 |
Are the icons good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this @ubuntujaggers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @ubuntujaggers !
Just a little nitpick, the button on the backdrop window is shifted on the new version of session-properties
:
Great spot @Jupi007 - I'll fix it asap 🙂 |
Fixed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, LGTM 👍
Hi everyone,
This is seeking to address #4163. I can either add the rest of the icons to this branch before we merge it, or we can just do multiple PRs to merge icons that are ready (assuming that people are happy with the new icons!).
The full size icon is still slightly bigger than I would like, because I would have liked the length of each side to be exactly halfway between the short and long sides of an oblong. Since the oblongs are 224 x 176, that would have meant a square of size 200 x 200. Unfortunately, when scaled to app grid size, 200px didn't shrink down to a whole number of pixels, meaning there was anti-aliasing round the edges. I've gone for 208 x 208px squares which are still noticeably smaller but render perfectly crisply on the app grid.
The revised icons in this branch (so far!) are as follows:
transmission
sudoku-app
tweaks-app
accessories-character-map
weather-app
wine
winetricks
session-properties
calculator-app
screenshot-app