Skip to content

Hotfix lang string for section #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amandadoughty merged 2 commits into from
Apr 30, 2026
Merged

Hotfix lang string for section #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
063e4ea
HOTFIX format_ucl: Added lang string to differentiate between name fo…
amandadoughty Apr 30, 2026
61f7296
HOTFIX format_ucl: Added lang string to differentiate between name fo…
amandadoughty Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lang/en/format_ucl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@
$string['pluginname'] = 'UCL Format';
$string['privacy:metadata'] = 'The UCL format plugin does not store any personal data.';
$string['section0name'] = 'Introduction';
$string['sectionname'] = 'New section';
$string['sectiondefaultname'] = 'New section';
$string['sectionname'] = 'Section';
$string['showfromothers'] = 'Show';
$string['toc'] = 'Table of contents';
$string['toofewmods'] = 'sections have one or less activities/resources';
Expand Down
4 changes: 2 additions & 2 deletions lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ public function get_section_name($section) {
return get_string('section0name', 'format_ucl');
}

if (get_string_manager()->string_exists('sectionname', 'format_ucl')) {
return get_string('sectionname', 'format_ucl');
if (get_string_manager()->string_exists('sectiondefaultname', 'format_ucl')) {
return get_string('sectiondefaultname', 'format_ucl');
}

// Return an empty string if there's no available section name string for the given format.
Expand Down
2 changes: 1 addition & 1 deletion tests/format_ucl_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function test_get_default_section_name(): void {
$sectionname = get_string('section0name', 'format_ucl');
$this->assertEquals($sectionname, $courseformat->get_default_section_name($section));
} else {
$sectionname = get_string('sectionname', 'format_ucl', $section->section);
$sectionname = get_string('sectiondefaultname', 'format_ucl', $section->section);
$this->assertEquals($sectionname, $courseformat->get_default_section_name($section));
}
}
Expand Down
Loading