Fixes #436: Server crashes when webhook onConnect fails

ueberdosis · Nov 7, 2022 · 2020e5b · 2020e5b
1 parent c39062c
commit 2020e5b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/extension-webhook/package.json b/packages/extension-webhook/package.json
@@ -29,6 +29,7 @@
     "dist"
   ],
   "dependencies": {
+    "@hocuspocus/common": "^1.0.0-beta.3",
     "@hocuspocus/server": "^1.0.0-beta.3",
     "@hocuspocus/transformer": "^1.0.0-beta.3",
     "axios": "^0.27.2"

diff --git a/packages/extension-webhook/src/index.ts b/packages/extension-webhook/src/index.ts
@@ -9,6 +9,7 @@ import {
 import { Doc } from 'yjs'
 import { TiptapTransformer, Transformer } from '@hocuspocus/transformer'
 import axios, { AxiosResponse } from 'axios'
+import { Forbidden } from '@hocuspocus/common'
 
 export enum Events {
   onChange = 'change',
@@ -175,8 +176,8 @@ export class Webhook implements Extension {
         ? JSON.parse(response.data)
         : response.data
     } catch (e) {
-      // eslint-disable-next-line no-throw-literal
-      throw null
+      console.error(`Caught error in extension-webhook: ${e}`)
+      throw Forbidden
     }
   }