fix(core): update the typing of addOptions, addStorage to have an…

… optional parent #5768 (#5770)
ueberdosis · Oct 28, 2024 · d2f366d · d2f366d
1 parent cc4b826
commit d2f366d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/happy-vans-smash.md b/.changeset/happy-vans-smash.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/core": patch
+---
+
+Updates the types of `addOptions` and `addStorage` to have the parent be possibly undefined which is the most accurate typing
diff --git a/packages/core/src/Extension.ts b/packages/core/src/Extension.ts
@@ -61,7 +61,7 @@ declare module '@tiptap/core' {
      */
     addOptions?: (this: {
       name: string
-      parent: Exclude<ParentConfig<ExtensionConfig<Options, Storage>>['addOptions'], undefined>
+      parent: ParentConfig<ExtensionConfig<Options, Storage>>['addOptions']
     }) => Options
 
     /**
@@ -76,7 +76,7 @@ declare module '@tiptap/core' {
     addStorage?: (this: {
       name: string
       options: Options
-      parent: Exclude<ParentConfig<ExtensionConfig<Options, Storage>>['addStorage'], undefined>
+      parent: ParentConfig<ExtensionConfig<Options, Storage>>['addStorage']
     }) => Storage
 
     /**

diff --git a/packages/core/src/Mark.ts b/packages/core/src/Mark.ts
@@ -64,7 +64,7 @@ declare module '@tiptap/core' {
      */
     addOptions?: (this: {
       name: string
-      parent: Exclude<ParentConfig<MarkConfig<Options, Storage>>['addOptions'], undefined>
+      parent: ParentConfig<MarkConfig<Options, Storage>>['addOptions']
     }) => Options
 
     /**
@@ -79,7 +79,7 @@ declare module '@tiptap/core' {
     addStorage?: (this: {
       name: string
       options: Options
-      parent: Exclude<ParentConfig<MarkConfig<Options, Storage>>['addStorage'], undefined>
+      parent: ParentConfig<MarkConfig<Options, Storage>>['addStorage']
     }) => Storage
 
     /**

diff --git a/packages/core/src/Node.ts b/packages/core/src/Node.ts
@@ -65,7 +65,7 @@ declare module '@tiptap/core' {
      */
     addOptions?: (this: {
       name: string
-      parent: Exclude<ParentConfig<NodeConfig<Options, Storage>>['addOptions'], undefined>
+      parent: ParentConfig<NodeConfig<Options, Storage>>['addOptions']
     }) => Options
 
     /**
@@ -80,7 +80,7 @@ declare module '@tiptap/core' {
     addStorage?: (this: {
       name: string
       options: Options
-      parent: Exclude<ParentConfig<NodeConfig<Options, Storage>>['addStorage'], undefined>
+      parent: ParentConfig<NodeConfig<Options, Storage>>['addStorage']
     }) => Storage
 
     /**