Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/y sync options: allow passing ySyncOptions to extension-collaboration #4976

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Feature/y sync options: allow passing ySyncOptions to extension-collaboration #4976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4b88b
extension-collaboration: allow passing ySyncOptions
janthurau Mar 13, 2024
00b085f
fixes import
janthurau Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/extension-collaboration/src/collaboration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import {
} from 'y-prosemirror'
import { UndoManager } from 'yjs'

type YSyncOpts = Parameters<typeof ySyncPlugin>[1]

declare module '@tiptap/core' {
interface Commands<ReturnType> {
collaboration: {
Expand Down Expand Up @@ -41,6 +43,8 @@ export interface CollaborationOptions {
* Fired when the content from Yjs is initially rendered to Tiptap.
*/
onFirstRender?: () => void,

ySyncOptions?: YSyncOpts
}

export const Collaboration = Extension.create<CollaborationOptions>({
Expand Down Expand Up @@ -149,8 +153,11 @@ export const Collaboration = Extension.create<CollaborationOptions>({
}
}

const onFirstRender = this.options.onFirstRender
const ySyncPluginOptions = onFirstRender ? { onFirstRender } : {}
const ySyncPluginOptions: YSyncOpts = {
...(this.options.ySyncOptions ? { ...this.options.ySyncOptions } : {}),
...(this.options.onFirstRender ? { ...this.options.onFirstRender } : {}),
}

const ySyncPluginInstance = ySyncPlugin(fragment, ySyncPluginOptions)

return [ySyncPluginInstance, yUndoPluginInstance]
Expand Down
Loading