Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): make all table packages be in one package, add a new TableKit extension to configure them #5469

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

nperez0111
Copy link
Contributor

Changes Overview

This represents a departure from our previous packaging approach. Instead of having a package for every single possible functionality that goes into the editor, we can reduce the number of packages by grouping them by functionality.
We believe that Tiptap's strength comes from it's modularity and this is no exception, each extension can still be installed separately, just under a new package namespace. But, it will definitely clean up your package.json to not have each component of a table as a package.

Implementation Approach

Following the approach set forth by @tiptap/extension-starter-kit this groups and installs the extensions for table all in a single package and import, greatly reducing duplication and reducing error of forgetting to install a package.

Once we decide that we like this approach, I can move forward with grouping:

  • text formatting: (bold, code, highlight, italic, strike, subscript, superscript, underline)
  • lists: (bullet list, ordered list, list item, list item keymap, task list, task item)
  • text styles: (color, font-family, text-align, text-style)

And, any other groupings that seem obvious to make.

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Aug 11, 2024

⚠️ No Changeset found

Latest commit: 0a2e970

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for tiptap-embed failed. Why did it fail? →

Name Link
🔨 Latest commit 0a2e970
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66ba6f4229644000087da8d3

@nperez0111 nperez0111 marked this pull request as draft August 11, 2024 17:20
@nperez0111
Copy link
Contributor Author

I've had a change of heart since implementing this, it may be worthwhile to keep the extraneous packages for at least one major version longer just to not break people on them changing their version. They should remove the packages but let's have a nicer upgrade experience. Also allows people to beta test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage open
Development

Successfully merging this pull request may close these issues.

1 participant