fix(react): Fix incorrect extensionAttributes value #5588
Conversation
🦋 Changeset detectedLatest commit: 963d5b7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const extensionAttributes = this.editor.extensionManager.attributes.filter( | ||
| attribute => attribute.type === this.node.type.name, | ||
| ) |
There was a problem hiding this comment.
Sorry, what did you run into that warrants this change? It is not clear to me why it is needed? It feels like something that is better placed as a responsibility of getRenderedAttributes instead
There was a problem hiding this comment.
The "attrs" function would accept all extensions' acttributes, it wasn't what i expected, it only need accpet relative extensions' acttributes. Maybe there's a better way to write it that I don't know?
Changes Overview
Prevent to call renderHTML function of all extensions.
Implementation Approach
Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues