fix(vue-3): late-registering plugins #5616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c28c1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nperez0111
reviewed
Sep 15, 2024
packages/vue-3/src/Editor.ts
Outdated
| if (this.reactiveState) { | ||
| this.reactiveState.value = this.view.state | ||
| this.reactiveState.value = state |
There was a problem hiding this comment.
This is the only real difference from what it was doing before no? Why do we need to duplicate what the editor class is doing?
The same was done for the unregistering, so I'd like to understand better what the actual problem was
There was a problem hiding this comment.
You are right. I’ve added more context to the PR's description. I'm using the reconfigured state directly since this.view.state is not updated at that point.
nperez0111
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
It seems that
y-prosemirror1.2.4 or 1.2.5 breaks late registering plugins, specifically in Vue 3. This might be related to a point Kevin mentioned here.The issue arises because
this.view.updateState(state)doesn't immediately updatethis.view.state. This delay means the reconfigured state inregisterPlugin()doesn't include newly registered plugins.Implementation Approach
To address this, I've adjusted the code to use the state returned by
this.state.reconfiguredirectly.Testing Done
I tested the changes, added Vue and React demos of a collaboration setup in combination with bubble and floating menu, and added tests.
Verification Steps
Open the
CollaborationWithMenusVue demo and check if collaboration and menus are working properly.Checklist
Related Issues
Closes #5259