Migrated navigator_test, navigator_gui, mil_poi, and mil_tools from ROS1 to ROS2
#1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 4, 2024 10:59
…tion-plan-Anvit i -m"I need to updtate my branch so i can push my code"
cbrxyz
requested changes
Apr 24, 2024
Member
cbrxyz
left a comment
cbrxyz
left a comment
There was a problem hiding this comment.
Thank you! Also, can you review whether CMakeLists.txt + package.xml will need to change for each package?
| # Sets the battery voltage to 'Unknown' if no message has been current in 15s | ||
| if ( | ||
| (rospy.Time.now() - self.battery_voltage["stamp"]) > rospy.Duration(15) | ||
| (rclpy.Time.now() - self.battery_voltage["stamp"]) > rclpy.Duration(15) |
Member
There was a problem hiding this comment.
rclpy.Time.now() does not exist in ROS 2
| monitor = HostMonitor() | ||
| rospy.Timer(rospy.Duration(10), monitor.publish, oneshot=False) | ||
| rospy.spin() | ||
| rclpy.Timer(rclpy.Duration(10), monitor.publish, oneshot=False) |
Member
There was a problem hiding this comment.
Timers aren't created in the same way either, you want to use your node to make timers
| self.get_logger().info("Camera info found!") | ||
| return self.camera_info | ||
| rospy.sleep(0.2) | ||
| rclpy.sleep(0.2) |
cbrxyz
changed the title
navigator_test, navigator_gui, mil_poi, and mil_tools from ROS1 to ROS2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I migrated the navigator_test, mil_tools , navigator_gui ,and mil_poi packages to ROS2.
Screenshot or Video
Related Issues
- Closes #XXX
Testing
About This PR