-
Notifications
You must be signed in to change notification settings - Fork 6
specify build-system #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request introduces a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
141-143: LGTM! This is a valuable addition that follows Python packaging best practices.The addition of the
[build-system]section withpoetry-coreis the recommended approach for Poetry projects. This explicit configuration:
- Ensures reproducible builds across different environments
- Follows PEP 517 standards for Python package building
- Uses the lightweight
poetry-coreinstead of full Poetry installation for buildsThis change will make the package more reliable to install in environments where the full Poetry package isn't available, such as in CI systems or when installing from source.
Summary by CodeRabbit