Skip to content

1431 eff tf cryo needs to be an input but keeping the existing default values #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmorris-uk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

1431 eff tf cryo needs to be an input but keeping the existing default values #3492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491b33b
Modified output in power.py for issue 1431
jmorris-uk Jan 21, 2025
32465d1
Minor ruff change
jmorris-uk Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 34 additions & 17 deletions process/power.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,23 +989,40 @@ def power2(self, output: bool):
"(tcoolin)",
tfcoil_variables.tcoolin,
)
# TODO: Both of these efficiencies are printed when it should be either 13% (ITER) or 40% (Strawbrige) - subset of TODO on line 1118
po.ovarre(
self.outfile,
"Efficiency (figure of merit) of cryogenic plant is 13% of ideal Carnot value:",
"",
(tfcoil_variables.eff_tf_cryo * tfcoil_variables.tmpcry)
/ (293.0e0 - tfcoil_variables.tmpcry),
"OP ",
)
po.ovarre(
self.outfile,
"Efficiency (figure of merit) of cryogenic aluminium plant is 40% of ideal Carnot value:",
"",
(tfcoil_variables.eff_tf_cryo * tfcoil_variables.tcoolin)
/ (293.0e0 - tfcoil_variables.tcoolin),
"OP ",
)

# Cryo-plants efficiencies
if abs(tfcoil_variables.eff_tf_cryo + 1) < 1e-6:
Copy link
Contributor

@jonmaddock jonmaddock Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you comment on the significance of this if?

# The ITER cyoplant efficiency is used for SC
if tfcoil_variables.i_tf_sup == 1:
po.ovarre(
self.outfile,
"Efficiency (figure of merit) of cryogenic plant is 13% of ideal Carnot value:",
"",
(tfcoil_variables.eff_tf_cryo * tfcoil_variables.tmpcry)
/ (293.0e0 - tfcoil_variables.tmpcry),
"OP ",
)
# Strawbrige plot extrapolation is used for Cryo-Al
elif tfcoil_variables.i_tf_sup == 2:
po.ovarre(
self.outfile,
"Efficiency (figure of merit) of cryogenic aluminium plant is 40% of ideal Carnot value:",
"",
(tfcoil_variables.eff_tf_cryo * tfcoil_variables.tcoolin)
/ (293.0e0 - tfcoil_variables.tcoolin),
"OP ",
)
else:
efficiency = tfcoil_variables.eff_tf_cryo * 100.0
po.ovarre(
self.outfile,
f"Efficiency (figure of merit) of cryogenic plant is {efficiency}% of ideal Carnot value (user input):",
"",
(tfcoil_variables.eff_tf_cryo * tfcoil_variables.tcoolin)
/ (293.0e0 - tfcoil_variables.tcoolin),
"OP ",
)

po.ovarre(
self.outfile,
"Electric power for cryogenic plant (MW)",
Expand Down
Loading