Skip to content

Conversation

@clmould
Copy link
Collaborator

@clmould clmould commented Dec 18, 2025

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Dec 18, 2025 that may be closed by this pull request
4 tasks
@clmould clmould requested a review from timothy-nunn December 18, 2025 16:31
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.63%. Comparing base (25480ae) to head (7f2f46f).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
- Coverage   45.89%   42.63%   -3.27%     
==========================================
  Files         123      123              
  Lines       29064    32413    +3349     
==========================================
+ Hits        13340    13820     +480     
- Misses      15724    18593    +2869     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes to tests and I'm 99% sure the changes to the model are fine but think a modeller should confirm it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you request a modeller to review just this file and check they are happy with this bit. Maybe @chris-ashe ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On running pytest a number of warnings are created which need fixing.

4 participants