Bugfix/84 uda server ssl authenticate #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a catch block for unknown_option errors instead of uncaught bad_any_cast exceptions being thrown for these
…updates work as expected
jholloc
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is that
UDA_CLIENT_SSL_AUTHENTICATEandUDA_SERVER_SSL_AUTHENTICATEmust now be set to a case-insensitive truthy value (1, true, on, yes) to enable SSL authentication. Previously these variables could be set to any value to enable (including falsey value like OFF or 0)The updated behaviour is checked in a new CI test within the SSL tests:
@jholloc main thing I want to check you're happy with before merging is the changes to uda_cli to return non-zero error codes. (and less critically function/namespace names in new uda_env utility).