Skip to content

Conversation

@stephen-dixon
Copy link
Collaborator

@stephen-dixon stephen-dixon commented Nov 5, 2025

Cached file-handle pointed to end of file after first call to bytes plugin. If called again on the same file this was not reset to the beginning by default. Main change is to reset the pointer to the beginning of the file by default.

Also:

  • adds try/catch in the C/C++ interface function as throwing functions now exist from std::filesystem.
  • changes offset datatype from int to unsigned long (would have had a maximum size of ~2GB before)
  • checks for nullptr before freeing for the out-of-memory error case

@stephen-dixon stephen-dixon requested a review from jholloc November 5, 2025 11:18
@stephen-dixon stephen-dixon merged commit d4a81f4 into develop Nov 5, 2025
13 of 25 checks passed
stephen-dixon added a commit that referenced this pull request Nov 7, 2025
* Dependabot bump actions/download-artifact from 4 to 6

* Bugfix/repeated bytes calls fail (#99): fixing multiple-read failures in getBytes plugin and typo in pyuda get_file method
@jholloc jholloc deleted the bugfix/repeated-bytes-calls-fail branch November 7, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants