Refactor the code to enable use of the local server without pytest. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it being in `__init__.py` caused setup to fail because of it triggering import of `paramiko`.
|
Code Climate has analyzed commit dd9ec15 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.3% (80% is the threshold). This pull request will bring the total coverage in the repository to 98.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Picking up this again now that I have another project that needs a proper SFTP server mock, but runs without pytest. I have corrected the code according to your suggestions, but somehow a force-push automatically closed my previous PR #6. Oh, well. Here comes a new one! 🙁 Let me know if you have any further suggestions.
Original PR description: