Skip to content

Conversation

@AndyButland
Copy link
Contributor

@AndyButland AndyButland commented Feb 2, 2026

Description

This PR fixes what I think is a regression, in that we are no longer seeing validation hints appear as expected on tabs.

I found this in investigating #21525 but it's not the same issue as is reported there. However I don't see this problem occurring before or after this fix, so if in review you also don't see it, it can likely be closed.

Testing

To verify the found problem, and that this update provides a fix:

  • Create a document type with two tabs, with a mandatory property on the second tab.
  • Create a document of that type.
  • Navigate to the first tab and attempt to save (or save and published) without filling the mandatory field on the second tab
  • Verify a validation badge appears on the second tab indicating it contains properties with errors.
image

To verify the reported problem, see the linked issue.

Copilot AI review requested due to automatic review settings February 2, 2026 08:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a visual bug where validation error badges were not appearing on document tabs when properties on inactive tabs had validation errors. The issue was caused by the umb-badge component using position: absolute by default, which caused it to be clipped by the tab's flex layout. The fix adds the inline-mode attribute to the badge, making it use position: relative with appropriate margin instead.

Changes:

  • Added inline-mode attribute to umb-badge in content editor tabs to fix badge clipping issue

Copy link
Contributor

@engijlr engijlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I just updated the position of the badge to be top left. Other than that works fine.

@AndyButland
Copy link
Contributor Author

Have also verified this after the updates, and confirm the issue remains fixed - thanks @engijlr.

image

@AndyButland AndyButland enabled auto-merge (squash) February 3, 2026 09:47
@AndyButland AndyButland merged commit 3ab7a03 into release/17.2 Feb 3, 2026
26 checks passed
@AndyButland AndyButland deleted the v17/bugfix/fix-display-of-validation-text-on-tab branch February 3, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants